AD command implementation in Calcite#4893
Closed
songkant-aws wants to merge 4 commits into
Closed
Conversation
Signed-off-by: Songkan Tang <songkant@amazon.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Signed-off-by: Songkan Tang <songkant@amazon.com>
songkant-aws
force-pushed
the
ad-operator
branch
from
1510d07 to
edfc81a
Compare
songkant-aws
changed the title
Signed-off-by: Songkan Tang <songkant@amazon.com>
Collaborator
Author
|
Close this PR as we won't do this implementation for now. The current algorithm doesn't fit well in large dataset case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement AD command in Calcite V3 engine
Related Issues
Resolves #4898
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.